critical bug fix

aloneguid · Dec 31, 2023 · fbd4a53 · fbd4a53
1 parent 0f46d34
commit fbd4a53
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -1,7 +1,7 @@
 name: 'Build'
 
 env:
-  VERSION: 4.18.0
+  VERSION: 4.18.1
   ASM_VERSION: 4.0.0
   DOC_ARTIFACT: webHelp-all.zip
 

diff --git a/docs/release-history.md b/docs/release-history.md
@@ -1,3 +1,7 @@
+## 4.18.1
+
+Critical bug fix: reverting #423 as it introducing some side effects that prevent from generating correct files.
+
 ## 4.18.0
 
 This is the next stability improvements release, and a big thanks to everyone who contributed! Without you this project would not be possible.

diff --git a/src/Parquet/File/DataColumnWriter.cs b/src/Parquet/File/DataColumnWriter.cs
@@ -84,7 +84,7 @@ private async Task CompressAndWriteAsync(
             ph.Write(new Meta.Proto.ThriftCompactProtocolWriter(headerMs));
             int headerSize = (int)headerMs.Length;
             headerMs.Position = 0;
-            // there used to be a flush here, but removed in #432 due to excessive flushing on expensive streams
+            _stream.Flush();
 
             await headerMs.CopyToAsync(_stream);