test for reflecting nullable TimeOnly

aloneguid · Feb 2, 2024 · d8febde · d8febde
1 parent f0f9901
commit d8febde
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/docs/release-history.md b/docs/release-history.md
@@ -2,7 +2,7 @@
 
 ### Bug fixes
 
-Fixed regression in schema discovery of nullables.
+Fixed regression in schema discovery of nullables for `DateTime`, `DateOnly`, `TimeOnly`.
 
 ## 4.23.3
 

diff --git a/src/Parquet.Test/Serialisation/SchemaReflectorTest.cs b/src/Parquet.Test/Serialisation/SchemaReflectorTest.cs
@@ -333,6 +333,8 @@ class DatesPoco {
 
             public TimeOnly DefaultTimeOnly { get; set; }
 
+            public TimeOnly? DefaultNullableTimeOnly { get; set; }
+
             [ParquetMicroSecondsTime]
             public TimeOnly MicroTimeOnly { get; set; }
 
@@ -422,6 +424,17 @@ public void Type_TimeOnly_Default() {
             DataField df = s.FindDataField(nameof(DatesPoco.DefaultTimeOnly));
             Assert.True(df is TimeOnlyDataField);
             Assert.Equal(TimeSpanFormat.MilliSeconds, ((TimeOnlyDataField)df).TimeSpanFormat);
+            Assert.False(df.IsNullable);
+        }
+
+        [Fact]
+        public void Type_TimeOnly_Nullable() {
+            ParquetSchema s = typeof(DatesPoco).GetParquetSchema(true);
+
+            DataField df = s.FindDataField(nameof(DatesPoco.DefaultNullableTimeOnly));
+            Assert.True(df is TimeOnlyDataField);
+            Assert.Equal(TimeSpanFormat.MilliSeconds, ((TimeOnlyDataField)df).TimeSpanFormat);
+            Assert.True(df.IsNullable);
         }
 
         [Fact]