Add DataExports endpoints #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelbeck
approved these changes
Sep 24, 2024
|
|
Hi, what about this PR ? Is ready soon to be added it in main ? |
joyet-simon
approved these changes
Feb 21, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change
Missing DataExport methods/endpoint.
Code changes
dataproperty to response class, since downloading the generated report file is not a JSON response and needs access to the "raw" response data.How to test
Call methods
create,fetchanddownloadon the DataExports endpoint, check responses and generated file output.Checklist for authors and reviewers
Have not written tests yet, since I don't have access to the internal docs and tools. Feel free to amend or give guidance on how to proceed. Thanks.