Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run CI on multiple PHP versions #108

Merged
merged 6 commits into from
Jun 4, 2024
Merged

Run CI on multiple PHP versions #108

merged 6 commits into from
Jun 4, 2024

Conversation

gdraynz
Copy link
Contributor

@gdraynz gdraynz commented May 24, 2024 •
edited
Loading

Run the CI on multiple versions of PHP.
These runs are non-blocking but give us an idea of what to fix or act on.

@gdraynz gdraynz changed the base branch from main to develop May 24, 2024 15:33
@gdraynz gdraynz force-pushed the devx/dex-861-continuous-integration branch from 812ee0a to 6202d8e Compare May 24, 2024 15:34
@gdraynz gdraynz force-pushed the devx/dex-861-continuous-integration branch from db48f7c to f2cde48 Compare May 24, 2024 15:53
@ClaireAlma ClaireAlma requested a review from a team May 27, 2024 09:38
@gdraynz gdraynz marked this pull request as ready for review May 28, 2024 07:44
@gdraynz gdraynz requested a review from a team May 28, 2024 07:44
@gdraynz gdraynz requested review from hyahiaoui and a team June 4, 2024 12:40
@gdraynz gdraynz force-pushed the devx/dex-861-continuous-integration branch from b1bdb7d to 27485a2 Compare June 4, 2024 12:41
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

remi-zuffinetti
remi-zuffinetti reviewed Jun 4, 2024
View reviewed changes
Copy link
Contributor

@remi-zuffinetti remi-zuffinetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the failure of the CI "expected"?
Do you want us to approve to merge "as is", and then with that proper CI, let integration developers fix the tests for higher PHP versions?

@gdraynz
Copy link
Contributor Author

gdraynz commented Jun 4, 2024

I feel like it is the best course yes.

remi-zuffinetti
remi-zuffinetti approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@remi-zuffinetti remi-zuffinetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we go then. Preferred to ask, as I'm not following the project closely

@gdraynz gdraynz merged commit 94b0deb into develop Jun 4, 2024
3 of 12 checks passed
gdraynz added a commit that referenced this pull request Jun 4, 2024
@gdraynz
Run CI on multiple PHP versions (#108)
7b0073b 
* Run CI on multiple PHP versions

* Remove fail-fast strategy

* Add more PHP versions

* Setup configuration file depending on the PHP version used

* Use proper ci phpunit xml file

* Revert change in phpunit.dist.legacy.xml
@Francois-Gomis Francois-Gomis deleted the devx/dex-861-continuous-integration branch July 11, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@remi-zuffinetti remi-zuffinetti remi-zuffinetti approved these changes

@hyahiaoui hyahiaoui Awaiting requested review from hyahiaoui

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gdraynz @hyahiaoui @remi-zuffinetti