feat!: Proper environment usage enforced #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kogitant
commented
Oct 12, 2022
kogitant
commented
- EnvironmentContext.isValid method added to validate provided environment name is allowed
- ProjectContect.tryGetEnvironment modified to return undefined if in the scope of AccountWrapper
- EnvironmentWrapper modified to throw an error if passed scope specifies an invalid environment (undefined or name does not match accepted patterns)
- Tests added to cover these cases
- npm run test passes
- npm run eslint passes
- npm run build passes and updated API.md
…environment name being used when naming things
…ent name is allowed ProjectContect.tryGetEnvironment modified to return undefined if in the scope of AccountWrapper EnvironmentWrapper modified to throw an error if passed scope specifies an invalid environment (undefined or name does not match accepted patterns) Tests added to cover these cases
kogitant
changed the title
kogitant
commented
Oct 12, 2022
| }); | ||
|
|
||
| test('Stack name is account wide even in environment context', () => { | ||
| expect(stack.stackName).toBe('TestProject-Account-TestStack'); |
There was a problem hiding this comment.
Getting this stackName was the problem that started this whole ball rolling. Before the other changes in this PR this would return a stack name that had Environment-development included in it. As far as I understand, that should not happen because we're creating the stack within AccountWrapper context (MockAccount class).
|
This feature will be address in upcoming V2/V3 major versions, as the whole account/environment handling will be redesigned. See roadmap: #36 Leaving this issue still open for reference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.