Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update docs (Migration Guide) and branding (Logo & Assets) #47

Merged
merged 66 commits into from
Nov 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
66 commits
Select commit Hold shift + click to select a range
3248a4d
docs: add SonarCloud badges
aripalo Nov 25, 2024
80fc55c
docs: improve migration guide
aripalo Nov 25, 2024
3d03792
docs: link to migration guide
aripalo Nov 25, 2024
562c5cf
docs: fix alignment
aripalo Nov 25, 2024
4d49cbe
docs: adjust styling
aripalo Nov 25, 2024
a9d942d
docs: adjust styling
aripalo Nov 25, 2024
3edbaae
docs: adjust header
aripalo Nov 25, 2024
e46a50b
docs: adjust header
aripalo Nov 25, 2024
aeef7c3
docs: adjust headings
aripalo Nov 25, 2024
91c857d
docs: improve
aripalo Nov 25, 2024
4bff50b
docs: be more explicit
aripalo Nov 25, 2024
6f161df
docs: improve migration guide
aripalo Nov 25, 2024
78445c7
docs: improve migration guide
aripalo Nov 25, 2024
389bc25
docs: mention roadmap
aripalo Nov 25, 2024
7af4800
docs: adjust spacing
aripalo Nov 25, 2024
8394fd4
docs: be more clear
aripalo Nov 25, 2024
99ccb8f
docs: fix typo
aripalo Nov 25, 2024
c352856
docs: document how to install the v1 (if v0 already installed)
aripalo Nov 25, 2024
0fcd5b8
docs: add migration tips
aripalo Nov 25, 2024
443d9b0
docs: add spacing
aripalo Nov 25, 2024
43d9e6d
chore: issue template for v1 migration bugs
aripalo Nov 25, 2024
5a483aa
docs: link to issues
aripalo Nov 25, 2024
b762ba2
docs: highlight the exception of tagging behaviour
aripalo Nov 25, 2024
7186d16
docs: highlight EXCEPTION word
aripalo Nov 25, 2024
d857ca4
docs: make the exception section important block
aripalo Nov 25, 2024
ad63ce0
docs: add section tittle
aripalo Nov 25, 2024
4420a77
docs: improve wording
aripalo Nov 25, 2024
7a72b73
docs: improve wording
aripalo Nov 25, 2024
378c2cf
docs: remove license badge as shields io seems unstable
aripalo Nov 25, 2024
adfa85b
docs: describe option to opt-out individual resources
aripalo Nov 25, 2024
ee8c9c0
docs: add warning about individual tag removals
aripalo Nov 25, 2024
0458bf1
docs: embed fonts into diagrams
aripalo Nov 25, 2024
b4117c4
docs: add stability and versioning badges
aripalo Nov 25, 2024
155989e
docs: updated logo and assets
aripalo Nov 25, 2024
b44257e
chore: ignore temp files created by Drawio and Affinity Designer
aripalo Nov 25, 2024
c554725
docs: separate README and Migration Guide
aripalo Nov 25, 2024
9766b59
docs: allow future majors to change nodejs support policy
aripalo Nov 25, 2024
bc9b73c
docs: improve wording
aripalo Nov 25, 2024
bae968d
docs: improve copy
aripalo Nov 25, 2024
f7798ae
docs: improve wording
aripalo Nov 25, 2024
148c13e
docs: improve
aripalo Nov 25, 2024
817cfb2
docs: add spacing
aripalo Nov 25, 2024
a05531d
docs: mention min nodejs requirement
aripalo Nov 25, 2024
71e8633
docs: strikethrough old min nodejs version
aripalo Nov 25, 2024
3510cc2
docs: style subject to change
aripalo Nov 25, 2024
134e138
docs: adjust link
aripalo Nov 25, 2024
e7a1a09
docs: add heading
aripalo Nov 25, 2024
da4953b
docs: fix link to package.json
aripalo Nov 25, 2024
4d6e40d
docs: improve wording
aripalo Nov 25, 2024
097ac57
docs: highlight the affected tags
aripalo Nov 25, 2024
24e4816
docs: improve wording
aripalo Nov 25, 2024
5effcd2
docs: improve wording
aripalo Nov 25, 2024
9bb9b65
docs: improve wording
aripalo Nov 25, 2024
cfc6ec4
docs: mention history
aripalo Nov 25, 2024
40e8ca1
docs: be more specific
aripalo Nov 25, 2024
39d0e71
docs: improve syntax
aripalo Nov 25, 2024
2bfd977
docs: mention @1 specifier
aripalo Nov 25, 2024
ee53aba
docs: "fixed" instead of "new"
aripalo Nov 25, 2024
8cc5151
docs: improve text flow
aripalo Nov 25, 2024
342318f
docs: be more explicit
aripalo Nov 25, 2024
9c73818
docs: shorten sentence
aripalo Nov 25, 2024
5e6be30
docs: adjust title
aripalo Nov 25, 2024
45e7186
docs: summary
aripalo Nov 26, 2024
895e3dc
docs: improve wording
aripalo Nov 26, 2024
00ad1c2
docs: inform about future of warning acks
aripalo Nov 26, 2024
f0c1bb8
docs: remove unnecessary warning section
aripalo Nov 26, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 54 additions & 0 deletions .github/ISSUE_TEMPLATE/v1-migration-issue.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
name: "V0 to V1 Migration Issue"
title: "Issue with V1 Migration: "
description: >
Report an issue with the V0 to V1 migration.
assignees:
- maintainers

labels:
- v1-migration-issue

body:

- type: dropdown
attributes:
label: Language
description: Programming Language used with AWS CDK
options:
- TypeScript/JavaScript
- Python
- Go
validations:
required: true

- type: input
attributes:
label: Version of aws-cdk-lib
description: >
AWS CDK Library version used
validations:
required: true

- type: input
attributes:
label: Version of aws-cdk
description: >
AWS CDK CLI/Toolkit version used
validations:
required: true

- type: input
attributes:
label: Original version of @alma-cdk/project
description: >
The v0 version used before migration to v1
validations:
required: true

- type: textarea
attributes:
label: Explain the problem
description: Do not disclose any sensitive information (including AWS Account IDs)!
placeholder: Tell us what happened. Do not disclose any sensitive information (including AWS Account IDs)!
validations:
required: true
2 changes: 2 additions & 0 deletions .gitignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions .projenrc.ts
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,8 @@ const project = new awscdk.AwsCdkConstructLibrary({
"/examples/**/.git",
"TODO.md",
".scannerwork/",
"**/*.drawio.bkp",
"**/*.afdesign~lock~",
],
});

Expand Down
63 changes: 24 additions & 39 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,38 +1,37 @@
<div align="center">
<br/>
<br/>
<h1>
<img width="300" src="assets/alma-cdk-project.svg" alt="Alma CDK Project" />
<img width="512" src="assets/alma-cdk-project.svg" alt="Alma CDK Project" />
<br/>
<br/>
</h1>

![NPM License](https://img.shields.io/npm/l/%40alma-cdk%2Fproject)
![Stability: Stable](https://img.shields.io/badge/stability-stable-%234BCA2A)
![Versioning: SemVer 2.0.0](https://img.shields.io/badge/versioning-semver_2.0.0-blue)
[![release](https://github.com/alma-cdk/project/actions/workflows/release.yml/badge.svg)](https://github.com/alma-cdk/project/actions/workflows/release.yml)
[![Quality Gate Status](https://sonarcloud.io/api/project_badges/measure?project=alma-cdk_project&metric=alert_status)](https://sonarcloud.io/summary/new_code?id=alma-cdk_project)
[![Coverage](https://sonarcloud.io/api/project_badges/measure?project=alma-cdk_project&metric=coverage)](https://sonarcloud.io/summary/new_code?id=alma-cdk_project)
<hr/>
</div>

```sh
npm i -D @alma-cdk/project
```
> [!Tip]
> Migrating from `v0` to `v1`? See [Migration Guide](/docs/MIGRATION-GUIDE-0-to-1.md).

<div align="left">
<br/>

Opinionated CDK “framework” with constructs & utilities for:
- deploying multiple environments to multiple accounts (with many-to-many relationship)
- managing account configuration through standardized props (no more random config files)
- querying account and/or environment specific information within your CDK code
- enabling dynamic & short-lived “feature-environments”
- enabling well-defined tagging
- providing structure & common conventions to CDK projects
- choosing the target account & environment by passing in runtime context:
Opinionated CDK “framework” with constructs & utilities for:
- deploying multiple environments to multiple accounts (with many-to-many relationship)
- managing account configuration through standardized props (no more random config files)
- querying account and/or environment specific information within your CDK code
- enabling dynamic & short-lived “feature-environments”
- enabling well-defined tagging
- providing structure & common conventions to CDK projects
- choosing the target account & environment by passing in runtime context:

```sh
npx cdk deploy -c account=dev -c environment=feature/abc-123
```
... which means you don't need to define all the possibile environments ahead of time!
```sh
npx cdk deploy -c account=dev -c environment=feature/abc-123
```
... which means you don't need to define all the possible environments ahead of time!

</div>
<br/>
</div>


## Account Strategies
Expand Down Expand Up @@ -214,20 +213,6 @@ Generally speaking you would be most interested in the following:
- EnvironmentContext (EC)
- Name / UrlName / PathName

## Migration

### v0 to v1
Migrating from `v0` to `v1`? See [Migration Guide](/docs/MIGRATION-GUIDE-0-to-1.md).

#### Tagging behavior

Due to a bug in `v0`, the `Contact` and `Organization` tags were NOT applied as they should have. This means that by default, upgrading from v0→v1 introduces CloudFormation diff. Basically adding the `Contact` and `Organization` tags to all resources. This should be safe operation, but we allow disabling it via a feature flag (note that `Contact` and `Organization` tags will most likely be enforced in future `v2`).

```diff
// cdk.json
{
"context": {
// existing context keys
+ "@alma-cdk/project:compatibilityV0Tags": true
},
}
```
<br/>
2 changes: 1 addition & 1 deletion assets/accounts-1x.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion assets/accounts-2x.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion assets/accounts-3x.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Loading