feat: improve Reth bindings and fix debug_traceCallMany and trace_callMany methods
#1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerosnacks
added
the
blocked
* Added stages to the sync info rpc type (#1079) * added stages detail * boxed enum * from hashmap to vec with helper type * serde alias and renames and dos * Update crates/rpc-types-eth/src/syncing.rs Co-authored-by: Matthias Seitz <[email protected]> * Update crates/rpc-types-eth/src/syncing.rs Co-authored-by: Matthias Seitz <[email protected]> * property to pub --------- Co-authored-by: Matthias Seitz <[email protected]> * removing async get account (#1080) * fix(node-bindings): backport fix from ethers-rs (#1081) * feat(consensus): add `From<ConsolidationRequest>` for `Request` (#1083) consensus: add From<ConsolidationRequest> for Request * fix(eips): make SignedAuthorizationList arbitrary less fallible (#1084) * chore: export rpc account type (#1075) * Update debug.rs * Update debug.rs --------- Co-authored-by: Luca Provini <[email protected]> Co-authored-by: Matthias Seitz <[email protected]> Co-authored-by: StackOverflowExcept1on <[email protected]> Co-authored-by: Thomas Coratger <[email protected]> Co-authored-by: Dan Cline <[email protected]>
yash-atreya
removed
the
blocked
|
With #1062 merged this can be picked up again @zerosnacks. Let me know if you have bandwidth for this. |
Yes, I'm picking it back up |
zerosnacks
commented
Sep 10, 2024
zerosnacks
changed the title
*_many methods don't work on Rethdebug_traceCallMany methods don't work on Reth
zerosnacks
changed the title
debug_traceCallMany methods don't work on Rethdebug_traceCallMany and trace_callMany methods don't work on Reth
mattsse
requested changes
Sep 11, 2024
Co-authored-by: Matthias Seitz <[email protected]>
…y-rs/alloy into zerosnacks/fix-all-many-methods-rpc
zerosnacks
requested review from
DaniPopes,
gakonst,
onbjerg,
prestwich and
emhane
as code owners
|
Undone unrelated changes. Kept:
As I think those a relevant to the newly added tests and future RPC tests |
zerosnacks
changed the title
debug_traceCallMany and trace_callMany methods don't work on Rethdebug_traceCallMany and trace_callMany methods
mattsse
reviewed
Sep 12, 2024
This was referenced Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes: #1074 and improves on Reth bindings added in #1092
Solution
Fixes
debug_traceCallManytrace_callManyOther
keys()/address()method for Reth binding - used in tracing but useful in general so you can perform transactionsrandom_instance()to reduce flakiness of concurrent spawned Reth nodesrun_with_tempdir_*methods for proper handling and clean up when using tempdirs + updating testsDoes not include the addition of
eth_callMany, to be added in #1274 and requires more consideration. Ties into #328 / #1119.PR Checklist