-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add tree hash root for BidTrace #1024
Comments
I think it could be as simple as:
and
But, we need to add the TreeHash trait impl for Address and Uint<> type in core too? Should I open a PR with the changes there first? |
makes sense, although, this crate currently only supports the ethereum_primitives: https://github.com/sigp/tree_hash https://github.com/sigp/tree_hash/blob/93d0e3ff58fb174f84dea8d2b5374787b7a4c85a/tree_hash/src/impls.rs#L2 the impls don't look to complex and I think we could easily feature gate them in alloy-primitives, like ssz but it's not ideal because the treehash API uses ethereum-types h256 ... fyi @DaniPopes |
If this gets released we don't need to add derives in alloy core sigp/tree_hash#16 |
oh nice! |
we (upstream tree_hash) will hopefully make progress on the alloy migration in the coming weeks |
Component
rpc
Describe the feature you would like
Generate the tree hash root for the BidTrace. In order to send the Bid to the relayer, the builder has to sign the hash tree root of the BidTrace.
Additional context
No response
The text was updated successfully, but these errors were encountered: