Skip to content

Commit

Permalink
feat(eth_call): fix serializion to include default block to latest
Browse files Browse the repository at this point in the history
  • Loading branch information
0xfourzerofour committed Jan 28, 2025
1 parent 4554735 commit 289afc9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
2 changes: 1 addition & 1 deletion crates/provider/src/provider/eth_call/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ mod test {
assert_eq!(params.overrides(), None);
assert_eq!(
serde_json::to_string(&params).unwrap(),
r#"[{"from":"0x0000000000000000000000000000000000000001","to":"0x0000000000000000000000000000000000000002","maxFeePerGas":"0x4a817c800","maxPriorityFeePerGas":"0x3b9aca00","gas":"0x5208","value":"0x64","nonce":"0x0","chainId":"0x1"}]"#
r#"[{"from":"0x0000000000000000000000000000000000000001","to":"0x0000000000000000000000000000000000000002","maxFeePerGas":"0x4a817c800","maxPriorityFeePerGas":"0x3b9aca00","gas":"0x5208","value":"0x64","nonce":"0x0","chainId":"0x1"},"latest"]"#
);

// Expected: [data, block, overrides]
Expand Down
4 changes: 1 addition & 3 deletions crates/provider/src/provider/eth_call/params.rs
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,10 @@ impl<N: Network> serde::Serialize for EthCallParams<'_, N> {

let mut seq = serializer.serialize_seq(Some(len))?;
seq.serialize_element(&self.data())?;
seq.serialize_element(&self.block().unwrap_or_default())?;

if let Some(overrides) = self.overrides() {
seq.serialize_element(&self.block().unwrap_or_default())?;
seq.serialize_element(overrides)?;
} else if let Some(block) = self.block() {
seq.serialize_element(&block)?;
}

seq.end()
Expand Down

0 comments on commit 289afc9

Please sign in to comment.