Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uallo values to get over uint64 (eg minStake) #107

Merged

Conversation

xmariachi
Copy link
Collaborator

@xmariachi xmariachi commented Jan 16, 2025

Purpose of Changes and their Description

Fix to use cosmosSdk.Int (ie big.Int) on uallo amounts.
This allows reputers to stake higher amounts than those covered by uint64.
Config changes type since this needs to specify such amounts as string in the json.

Are these changes tested and documented?

  • If tested, please describe how. If not, why tests are not needed. -- Tested locally
  • If documented, please describe where. If not, describe why docs are not needed. -- Modified README accordingly
  • Added to Unreleased section of CHANGELOG.md?

@xmariachi xmariachi changed the title config example change of string uallo values uallo values to get over uint64 (eg minStake) Jan 16, 2025
@xmariachi xmariachi marked this pull request as ready for review January 16, 2025 12:13
@xmariachi xmariachi requested a review from felipead January 16, 2025 12:47
@xmariachi xmariachi merged commit 23c2cad into dev Jan 16, 2025
4 of 5 checks passed
@xmariachi xmariachi deleted the diego/proto-3254-reputer-cannot-use-minstake-over-int-value branch January 16, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants