Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x: fix some function names in comment #731

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

x: fix some function names in comment #731

wants to merge 1 commit into from

Conversation

kindknow
Copy link

@kindknow kindknow commented Dec 29, 2024 •
edited
Loading

Purpose of Changes and their Description

fix some function names in comment

Link(s) to Ticket(s) or Issue(s) resolved by this PR

Are these changes tested and documented?

  • If tested, please describe how. If not, why tests are not needed.
  • If documented, please describe where. If not, describe why docs are not needed.
  • Added to Unreleased section of CHANGELOG.md?

Still Left Todo

Fill this out if this is a Draft PR so others can help.

@kpeluso
Copy link
Collaborator

kpeluso commented Jan 4, 2025

@kindknow please be sure to sign your commits. Consider making a new PR with these changes after you ensure you're signing your commits.

@kindknow
Copy link
Author

kindknow commented Jan 5, 2025

@kindknow please be sure to sign your commits. Consider making a new PR with these changes after you ensure you're signing your commits.

Thanks. Signed.
image

amimart
amimart approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@amimart amimart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's better thanks :)

@kindknow
Copy link
Author

kindknow commented Jan 9, 2025

That's better thanks :)

Thanks for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amimart amimart amimart approved these changes

@kpeluso kpeluso kpeluso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kindknow @kpeluso @amimart