Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: push breakdown in modal and facto wrapper #79

Merged
merged 4 commits into from
May 1, 2024

Conversation

alexiscolin
Copy link
Member

Refactor modal UI to avoid DRY between ModalWrap & ModalBox and push breakdown details into a modal

@alexiscolin alexiscolin marked this pull request as draft April 22, 2024 14:46
Copy link

netlify bot commented Apr 22, 2024

Deploy Preview for govgen-governance-dapp ready!

Name Link
🔨 Latest commit 9f2bbbc
🔍 Latest deploy log https://app.netlify.com/sites/govgen-governance-dapp/deploys/663168675dc26c00080e0729
😎 Deploy Preview https://deploy-preview-79--govgen-governance-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alexiscolin alexiscolin marked this pull request as ready for review April 22, 2024 14:50
@alexiscolin alexiscolin marked this pull request as draft April 22, 2024 14:55
@alexiscolin alexiscolin marked this pull request as ready for review April 22, 2024 15:04
clockworkgr
clockworkgr previously approved these changes Apr 23, 2024
@clockworkgr
Copy link
Member

@alexiscolin can you check out the merge conflicts so we can merge?

@clockworkgr clockworkgr merged commit 9c30c8c into main May 1, 2024
9 checks passed
@clockworkgr clockworkgr deleted the refactor/popup branch May 1, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants