-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:minor edits to gravity-dex.md #1
base: main
Are you sure you want to change the base?
Conversation
Applied several editorial standards throughout content, no substantive changes Doc is so improved! Good job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kogisin thanks for looking at these editorial changes!
|
||
2. Replace necessary configuration | ||
3. Run these commands to configure the seed nodes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of "Replace necessary configuration" I think we're saying to run these commands?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I think it is better.
@kogisin I see the repo is still not protected, can we fix that? |
@barriebyron Thanks for looking into this docs! As always, your feedback and suggestions are very helpful.
What do you mean by "not protected"? Can you elaborate? |
Hi @kogisin I had the option to merge the PR without any approvals (oops). The repo is brand new, I see. I had the distinct pleasure to create PR 1. Best practice is to require approvals before allowing PRs to be merged into the main branch. See and do you know about accepting the commit suggestions? You can go through one by one and add to batch so all changes apply to a single commit. You can even edit the suggestion before you accept or add to batch. https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/incorporating-feedback-in-your-pull-request |
Like you said, the repo is brand new and I didn’t expect to collaborate with anyone anytime soon, but here you are. Thanks! I just added the protection rule for all branches. All PRs require at least 1 review and status checks need to be passed before merging. |
### Hardware Requirements | ||
|
||
Minimum requirements | ||
|
||
- 2 Core CPU | ||
- 8GB RAM | ||
- 8 GB RAM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not know we need space between the number and gigabytes. Is this conventional?
|
||
2. Another change to make in the `$HOME/.gaia/config/config.toml` file is to increase the timeout for a transaction to be committed and maximum size of request body and header. Since IBC and swap state transactions are very large, your node might stop from time to time when your node receives too many requests. Configure these values to increase the timeout: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to locate the field down to part 2 since part 1 only deals with setting up the peers list.
# The ibc and swap state are very large, causing the node itself
# to stop on excessive queries. Therefore, we customize the rpc configuration
# as above.
# How long to wait for a tx to be committed during /broadcast_tx_commit.
# WARNING: Using a value larger than 10s will result in increasing the
# global HTTP write timeout, which applies to all connections and endpoints.
# See https://github.com/tendermint/tendermint/issues/3435
timeout_broadcast_tx_commit = "600s"
Applied several editorial standards throughout the content, no substantive changes.
Doc is so improved! Good job, I am very excited to see this evolution.
Highlights