Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:minor edits to gravity-dex.md #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

barriebyron
Copy link

@barriebyron barriebyron commented Aug 20, 2021

Applied several editorial standards throughout the content, no substantive changes.
Doc is so improved! Good job, I am very excited to see this evolution.

Highlights

Applied several editorial standards throughout content, no substantive changes
Doc is so improved! Good job
@barriebyron barriebyron self-assigned this Aug 20, 2021
Copy link
Author

@barriebyron barriebyron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kogisin thanks for looking at these editorial changes!


2. Replace necessary configuration
3. Run these commands to configure the seed nodes:
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of "Replace necessary configuration" I think we're saying to run these commands?

Copy link
Contributor

@jaybxyz jaybxyz Aug 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I think it is better.

@barriebyron
Copy link
Author

@kogisin I see the repo is still not protected, can we fix that?

@jaybxyz
Copy link
Contributor

jaybxyz commented Aug 21, 2021

@barriebyron Thanks for looking into this docs! As always, your feedback and suggestions are very helpful.

I see the repo is still not protected, can we fix that?

What do you mean by "not protected"? Can you elaborate?

@barriebyron
Copy link
Author

@barriebyron Thanks for looking into this docs! As always, your feedback and suggestions are very helpful.

I see the repo is still not protected, can we fix that?

What do you mean by "not protected"? Can you elaborate?

Hi @kogisin I had the option to merge the PR without any approvals (oops). The repo is brand new, I see. I had the distinct pleasure to create PR 1. Best practice is to require approvals before allowing PRs to be merged into the main branch. See
https://docs.github.com/en/github/administering-a-repository/defining-the-mergeability-of-pull-requests/managing-a-branch-protection-rule

and do you know about accepting the commit suggestions? You can go through one by one and add to batch so all changes apply to a single commit. You can even edit the suggestion before you accept or add to batch. https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/incorporating-feedback-in-your-pull-request

@jaybxyz
Copy link
Contributor

jaybxyz commented Aug 22, 2021

Like you said, the repo is brand new and I didn’t expect to collaborate with anyone anytime soon, but here you are. Thanks! I just added the protection rule for all branches. All PRs require at least 1 review and status checks need to be passed before merging.

### Hardware Requirements

Minimum requirements

- 2 Core CPU
- 8GB RAM
- 8 GB RAM
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not know we need space between the number and gigabytes. Is this conventional?


2. Another change to make in the `$HOME/.gaia/config/config.toml` file is to increase the timeout for a transaction to be committed and maximum size of request body and header. Since IBC and swap state transactions are very large, your node might stop from time to time when your node receives too many requests. Configure these values to increase the timeout:
Copy link
Contributor

@jaybxyz jaybxyz Aug 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to locate the field down to part 2 since part 1 only deals with setting up the peers list.

# The ibc and swap state are very large, causing the node itself 
# to stop on excessive queries. Therefore, we customize the rpc configuration 
# as above.

# How long to wait for a tx to be committed during /broadcast_tx_commit.
# WARNING: Using a value larger than 10s will result in increasing the
# global HTTP write timeout, which applies to all connections and endpoints.
# See https://github.com/tendermint/tendermint/issues/3435
timeout_broadcast_tx_commit = "600s"

@jaybxyz jaybxyz added enhancement New feature or request documentation Improvements or additions to documentation and removed enhancement New feature or request labels Aug 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants