Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tenatively update mms to C++17 #128

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Conversation

sapphonie
Copy link
Contributor

No description provided.

@sapphonie
Copy link
Contributor Author

alliedmodders/hl2sdk#144 needs merged first

@dvander
Copy link
Member

dvander commented Oct 9, 2023

/usr/bin/../lib/gcc/x86_64-linux-gnu/10/../../../../include/c++/10/bits/stl_algo.h:3698:63: error: too many arguments provided to function-like macro invocation
    clamp(const _Tp& __val, const _Tp& __lo, const _Tp& __hi, _Compare __comp)
                                                              ^
/home/runner/work/metamod-source/metamod-source/dependencies/hl2sdk-dota/public/mathlib/mathlib.h:635:9: note: macro 'clamp' defined here
#define clamp(val, min, max) (((val) > (max)) ? (max) : (((val) < (min)) ? (min) : (val)))

Usually we rename clamp to V_clamp in SDKs to avoid hitting this, looks like we forgot dota.

@sapphonie
Copy link
Contributor Author

/usr/bin/../lib/gcc/x86_64-linux-gnu/10/../../../../include/c++/10/bits/stl_algo.h:3698:63: error: too many arguments provided to function-like macro invocation
    clamp(const _Tp& __val, const _Tp& __lo, const _Tp& __hi, _Compare __comp)
                                                              ^
/home/runner/work/metamod-source/metamod-source/dependencies/hl2sdk-dota/public/mathlib/mathlib.h:635:9: note: macro 'clamp' defined here
#define clamp(val, min, max) (((val) > (max)) ? (max) : (((val) < (min)) ? (min) : (val)))

Usually we rename clamp to V_clamp in SDKs to avoid hitting this, looks like we forgot dota.

CSGO as well and idk how many other ones.

@dvander dvander merged commit 437de2b into alliedmodders:master Oct 13, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants