convert UTIL_TrimRight/TrimLeft to use std string internally #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #118
Would convert these to take std::string& but they are surrounded by so much C code that it would be way too much of a pain. That's up next, though it really should be commented first for easier rewriting...
Well, eventually. I am bad at C.
This std string trimming code is from stack overflow, over @ https://stackoverflow.com/a/217605 - it's been referenced so many times and is so short that I don't really think there's any point in trying to rewrite the wheel.
I also don't want to use strcpy, but there's not a better way and it's not unsafe because the string is guaranteed to always be the same size or smaller.
Edit:
Also, this requires
<algorithm>, so be aware