extend pragma #914
Open
extend pragma #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
extending pragma with option and warning. |
afwn90cj93201nixr2e1re
force-pushed
the
new_pragmas
branch
from
6ba537f
to
7cb045c
Compare
New pragmas: option, warning. New simplified zero division detector. Fixed const scopes. Fixed 'assigned to itself' warning on multidimensional array's cell's (invertion operators).
afwn90cj93201nixr2e1re
force-pushed
the
new_pragmas
branch
from
1ab8e20
to
c0844cc
Compare
voed
approved these changes
Nov 26, 2020
dvander
reviewed
Dec 6, 2020
| @@ -1209,6 +1236,8 @@ static int hier2(value *lval) | |||
| rvalue(lval); | |||
| invert(); /* bitwise NOT */ | |||
| lval->constval=~lval->constval; | |||
| if (lval->ident==iVARIABLE || lval->ident==iARRAYCELL) | |||
| lval->ident=iEXPRESSION; | |||
There was a problem hiding this comment.
These are long-standing bugs - but are they related to this change? If not, it's best to separate them for purposes of bisection.
There was a problem hiding this comment.
Actually, it looks like there are many individual bug changes in this patch...
There was a problem hiding this comment.
Should i just separate them? Or it's possible to change pr title instead? (Coz i just took arkshine style, he used 1 pr to update/fix few things in compiler, github.com/alliedmodders/amxmodx/ pull/137).
There was a problem hiding this comment.
@dvander need answers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.