KANBAN-591

[adamgibs]

TESTING -- DO NOT MERGE

[sethrcamp]

Left a few thoughts, but overall looks pretty straight forward (although I am sure it looks much more straightforward than it was to actually upgrade everything).

[sethrcamp]

I think you can get away with:

if (checkboxValue && orthology.data.results)

on line 102. That should also let you get rid of the "?" chains for lines 103, 106, and 109.

[sethrcamp]

A few thoughts here:

1. Since this is wrapped in if (summary.data), then you shouldn't need the first "?" (i.e. `summary.data.categories?..."

2. "categories" can be undefined if data.categories is undefined. Just curious if this is intentional.

3. This is a pretty minor optimization, but both "selectedOrthologs" and "geneTaxon" are not dependant on the categories array, meaning selectedOrthologs.length === 0 && geneTaxon === taxonIdYeast will be the same for every category. Rewriting it this way will reduce the number of times the comparison will be made to 1 (or O(1) to be fancy):

let updatedSummary;
if (summary.data) {
  const taxonIdYeast = 'NCBITaxon:559292';
  let categories = summary.data.categories;
  if (categories && selectedOrthologs.length === 0 && geneTaxon === taxonIdYeast) {
    categories = categories.filter(category => !category.id.startsWith('UBERON:');
  }
  ...
}

4. Lastly, updatedSummary = summary.data; will be a pointer reference, meaning updatedSummary.categories = categories; will change the value for both "summary" and "updatedSummary". I don't recall if react query supports this, but either way, if this isn't intentional, I would change to this instead:

updatedSummary = {
  ...summary.data,
  categories
};

[sethrcamp]

Here's a little shorthand if you like avoiding ternaries:

return (resolvedData || []).map(allele => ... );

[adamgibs]

@sethrcamp Pushed out code to address your comments. Thanks!