SCRUM-3648 #1281
Merged
SCRUM-3648 #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abecerra
approved these changes
Mar 7, 2024
oblodgett
reviewed
Mar 7, 2024
| }, | ||
| { | ||
| dataField: 'subject.taxon', | ||
| text: 'Species', | ||
| headerStyle: { width: '100px' }, | ||
| formatter: species => <SpeciesCell species={species} />, | ||
| filterName: 'species', | ||
| filterable: getDistinctFieldValue(resolvedData, 'species').sort(compareByFixedOrder(SPECIES_NAME_ORDER)), |
There was a problem hiding this comment.
@adamgibs does this not come from the backed correctly? I would think this ordering needs to be sorted on the backend?
There was a problem hiding this comment.
@oblodgett Yeah, this is needed to get the list in phylogenetic order. I don't know if it needs to come from the backend ordered or not. It hasn't been in the past. This sorting method is used in other annotation tables on the site as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.