KANBAN-591 remove disease sort from allele table

alliance-genome · Jan 23, 2025 · c4d452f · c4d452f
1 parent bedcef8
commit c4d452f
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 10 deletions.
diff --git a/src/components/dataTable/ExperimentalConditionCellCuration.js b/src/components/dataTable/ExperimentalConditionCellCuration.js
@@ -1,14 +1,16 @@
 import React from 'react';
+import hash from 'object-hash';
 
 const ExperimentalConditionCellCuration = ({ conditions }) => {
   return conditions? (
     <dl>
       {
         conditions.map(condition=> {
-          const { conditions, id } = condition;
+          const { conditions } = condition;
           const summaries = conditions.map(({conditionSummary}) => conditionSummary);
+          const key = hash(condition);
           return (
-            <React.Fragment key={id}>
+            <React.Fragment key={key}>
               <dt>{condition.conditionRelationType.name.replace(/_/, ' ')}:</dt>
               <dd>
                 {summaries.map(summary => (

diff --git a/src/components/dataTable/evidenceCodesCellCuration.js b/src/components/dataTable/evidenceCodesCellCuration.js
@@ -25,7 +25,7 @@ const EvidenceCodesCellCuration = ({evidenceCodes}) => {
 
 EvidenceCodesCellCuration.propTypes = {
   evidenceCodes: PropTypes.arrayOf(PropTypes.shape({
-    id: PropTypes.string,
+    id: PropTypes.number,
     name: PropTypes.string,
     displaySynonym: PropTypes.string,
   })),

diff --git a/src/containers/diseasePage/DiseaseToAlleleTable.js b/src/containers/diseasePage/DiseaseToAlleleTable.js
@@ -153,7 +153,7 @@ const DiseaseToAlleleTable = ({id}) => {
       columns={columns}
       data={rows}
       downloadUrl={`/api/disease/${id}/alleles/download`}
-      keyField='primaryKey'
+      keyField='uniqueId'
       sortOptions={sortOptions}
     />
   );

diff --git a/src/containers/diseasePage/DiseaseToGeneTable.js b/src/containers/diseasePage/DiseaseToGeneTable.js
@@ -179,7 +179,7 @@ const DiseaseToGeneTable = ({ id }) => {
       columns={columns}
       data={rows}
       downloadUrl={`/api/disease/${id}/genes/download`}
-      keyField='primaryKey'
+      keyField='uniqueId'
       sortOptions={sortOptions}
     />
   );

diff --git a/src/containers/diseasePage/DiseaseToModelTable.js b/src/containers/diseasePage/DiseaseToModelTable.js
@@ -167,7 +167,7 @@ const DiseaseToModelTable = ({id}) => {
       columns={columns}
       data={data}
       downloadUrl={`/api/disease/${id}/models/download`}
-      keyField='primaryKey'
+      keyField='uniqueId'
       sortOptions={sortOptions}
     />
   );

diff --git a/src/containers/genePage/alleleTable.js b/src/containers/genePage/alleleTable.js
@@ -280,10 +280,6 @@ const AlleleTable = ({ isLoadingGene, gene, geneId}) => {
     //   value: 'alleleSymbol',
     //   label: 'Allele symbol',
     // }, // default
-    {
-      value: 'disease',
-      label: 'Associated Human Disease',
-    },
     {
       value: 'variant',
       label: 'Variant',