Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCRUM-3693: roll down MaTI DB between environments #72

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Conversation

abecerra
Copy link
Collaborator

@abecerra abecerra commented Feb 9, 2024

  • Fix the integration tests failure (SCRUM-3692) imposing ordering and making the GET counters endpoint public
  • Adds a persistence unit "rolldown" to roll down the DB. For production it is be the beta database, for beta it is the alpha database
  • Adds the code to roll down the MaTI db for curation, easily extensible for the ABC literature system.

Copy link

gitguardian bot commented Feb 9, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9412085 Triggered Generic Password 1b46566 src/main/resources/application.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@abecerra
Copy link
Collaborator Author

abecerra commented Feb 9, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

username and password in application.yml for local development were set before activating gitguardian. No security compromise

@mluypaert
Copy link
Member

Will close and re-open this PR in attempt to retrigger PR validation actions (which are currently being skipped, probably because the PR message body was edited shortly after PR creation)..

@mluypaert mluypaert closed this Feb 9, 2024
@mluypaert mluypaert reopened this Feb 9, 2024
@mluypaert
Copy link
Member

Will close and re-open this PR in attempt to retrigger PR validation actions (which are currently being skipped, probably because the PR message body was edited shortly after PR creation)..

Close & reopen did the trick, PR validation is running now: https://github.com/alliance-genome/agr_mati/actions/runs/7846680755?pr=72

@abecerra abecerra merged commit 47634df into main Feb 13, 2024
9 checks passed
@abecerra abecerra deleted the SCRUM-3692 branch February 13, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants