Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCRUM-3361: add secondary data provider #1152

Closed
wants to merge 1 commit into from
Closed

SCRUM-3361: add secondary data provider #1152

wants to merge 1 commit into from

Conversation

abecerra
Copy link
Contributor

No description provided.

@abecerra abecerra requested review from cmpich and oblodgett January 31, 2024 10:33
cmpich
cmpich approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@cmpich cmpich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

cmpich
cmpich requested changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@cmpich cmpich left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an AND operation on main data provider and secondary data provider with the same value. That is not going to work.

Need to make an OR operation between the two fields.

@abecerra
Copy link
Contributor Author

Do we need a should query?

https://jolicode.com/blog/how-to-build-a-or-condition-in-elasticsearch-query-dsl

@abecerra abecerra closed this Jan 31, 2024
@oblodgett oblodgett deleted the SCRUM-3361 branch January 26, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmpich cmpich cmpich requested changes

@oblodgett oblodgett oblodgett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abecerra @oblodgett @cmpich