Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-17: x.com urls do not get embedded properly #18

Merged
merged 4 commits into from
Mar 27, 2024

Conversation

mogmarsh
Copy link
Contributor

@mogmarsh mogmarsh commented Mar 27, 2024

Description of the bug

links to x.com tweets instead of twitter.com don't get embedded properly. This issue has been addressed by ensuring that URLs from x.com are properly embedded similar to those from twitter.com.

Steps To Reproduce

try converting the following:
<p>https://x.com/alleyco/status/1679189879086018562</p>

Additional Information

A changelog entry has been added to document the changes made to resolve this issue.

@mogmarsh mogmarsh marked this pull request as ready for review March 27, 2024 14:48
Copy link
Member

@kevinfodness kevinfodness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍣

@mogmarsh mogmarsh merged commit c643d2c into develop Mar 27, 2024
6 checks passed
@mogmarsh mogmarsh deleted the fix/issue-17/x-com-urls-embed-issue branch March 27, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants