Ensure cite does not get stripped

alleyinteractive · Feb 18, 2025 · ecf1945 · ecf1945
1 parent 4d8f41d
commit ecf1945
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/class-block-converter.php b/src/class-block-converter.php
@@ -110,7 +110,7 @@ public function convert_node( DOMNode $node ): ?Block {
 				'h1', 'h2', 'h3', 'h4', 'h5', 'h6' => $this->h( $node ),
 				'p', 'a', 'abbr', 'b', 'code', 'em', 'i', 'strong', 'sub', 'sup', 'span', 'u' => $this->p( $node ),
 				'figure' => $this->figure( $node ),
-				'br', 'cite', 'source' => null,
+				'br', 'source', 'cite' => null,
 				'hr' => $this->separator(),
 				default => $this->html( $node ),
 			};
@@ -214,6 +214,11 @@ public function convert_with_children( DOMNode $node ): string {
 				continue;
 			}
 
+			// Ensure that the cite tag is not converted to a block.
+			if ( 'cite' === strtolower( $child->nodeName ) ) {
+				$children .= trim( static::get_node_html( $child ) );
+			}
+
 			$child_block = $this->convert_node( $child );
 
 			if ( ! empty( $child_block ) ) {

diff --git a/tests/feature/BlockConverterTest.php b/tests/feature/BlockConverterTest.php
@@ -92,6 +92,10 @@ public static function converter_data_provider() {
 				'<blockquote><p>Lorem ipsum</p></blockquote>',
 				'<!-- wp:quote --><blockquote class="wp-block-quote"><!-- wp:paragraph --><p>Lorem ipsum</p><!-- /wp:paragraph --></blockquote><!-- /wp:quote -->',
 			],
+			'blockquote with cite' => [
+				'<blockquote><p>Lorem ipsum</p><cite>Source</cite></blockquote>',
+				'<!-- wp:quote --><blockquote class="wp-block-quote"><!-- wp:paragraph --><p>Lorem ipsum</p><!-- /wp:paragraph --><cite>Source</cite></blockquote><!-- /wp:quote -->',
+			],
 			'non-oembed-embed' => [
 				'<embed type="video/webm" src="/media/mr-arnold.mp4" width="250" height="200" />',
 				'<!-- wp:html --><embed type="video/webm" src="/media/mr-arnold.mp4" width="250" height="200"></embed><!-- /wp:html -->',