Fieldmanager Webpack setup for JS and CSS minification #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenslack
commented
Nov 17, 2020
webpack.config.js
Outdated
| // postcss-preset-env includes autoprefixer | ||
| 'postcss-preset-env', | ||
| { | ||
| browsers: 'last 2 versions', |
There was a problem hiding this comment.
This may need to be adjusted but for the most cases the -webkit and -moz prefixes are added here with autoprefixer
There was a problem hiding this comment.
Consider adding this to package.json via the browserslist field (or a .browserslistrc file) instead so other tools like Babel can make use of it too. 🙂
https://github.com/csstools/postcss-preset-env#browsers
https://babeljs.io/docs/en/babel-preset-env
montchr
suggested changes
Nov 17, 2020
webpack.config.js
Outdated
| // postcss-preset-env includes autoprefixer | ||
| 'postcss-preset-env', | ||
| { | ||
| browsers: 'last 2 versions', |
There was a problem hiding this comment.
Consider adding this to package.json via the browserslist field (or a .browserslistrc file) instead so other tools like Babel can make use of it too. 🙂
https://github.com/csstools/postcss-preset-env#browsers
https://babeljs.io/docs/en/babel-preset-env
…e targets, compile files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should serve as a springboard to using Webpack as a build system. This PR has the following characteristics:
builddirectoryautoprefixerto CSS properties using PostCSSFuture efforts may want to include:
NOTE:
Currently, the CSS files in the entry points also generate a JS file in the build even if there is no associated JS file.