Sanitize post types when adding meta boxes #692
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recenlty, I added a meta box with a code like that:
by adding accidentally a blank space in the post type.
I notice that the box is still added, since behind the scenes, the type value is sanified.
However this is not be done when saving/updating post, so the custom fields are not updated.
I spent some time to understand why :-) so the patch try to solve that by sanitizing
post_types
values on constructors.I had to check
post_types
type values since, even if the doc says that must be strings, many tests use$field->add_meta_box( 'test meta box', $this->post );
and I think they should be fixed (it will simplify also this PR).Note that command above doesn't fail and doesn't do anyting due to this.