Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent delete for revisions #1216

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Prevent delete for revisions #1216

wants to merge 5 commits into from

Conversation

mslinnea
Copy link
Member

@mslinnea mslinnea commented Jan 30, 2025

We've discovered an issue where the deletion of an autosave can trigger the Apple News article to be deleted.

Typically, autosaves don't have post meta, so this isn't a widespread issue.

@mslinnea mslinnea changed the title Prevent delete for autosave Prevent delete for revisions Jan 30, 2025
@mslinnea mslinnea linked an issue Jan 30, 2025 that may be closed by this pull request
Copy link

@scottnelle scottnelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but it may be worth checking with @kevinfodness and @renatonascalves to determine if updating the version is preferred in the PR where the change is made or in a separate release PR. I've seen it handled both ways. Either way, it looks like you should update the version in package.json, as well. 👻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Posts getting deleted from Apple News
2 participants