Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix merging of values to override inline values last #815

Merged
merged 2 commits into from
Dec 26, 2024
Merged

Fix merging of values to override inline values last #815

merged 2 commits into from
Dec 26, 2024

Conversation

allenporter
Copy link
Owner

@allenporter allenporter commented Dec 26, 2024

https://fluxcd.io/flux/components/helm/helmreleases/#values-references specifies that values are merged last after any valuesFrom references.

Fixes #813

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.53%. Comparing base (e4a668c) to head (91a5c6a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #815   +/-   ##
=======================================
  Coverage   93.53%   93.53%           
=======================================
  Files          20       20           
  Lines        2304     2306    +2     
=======================================
+ Hits         2155     2157    +2     
  Misses        149      149           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@allenporter allenporter merged commit e3f6de8 into main Dec 26, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deep merge issue broke substitutions in 6.1.0
2 participants