-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'Remove step' feature for local workspaces #588
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the function in the workspace should be an abstract method: "NotImplementedError" , and this function is specifically for "local_workspace".
The remote workspaces that inherit from local workspace can implement the remove method as follows:
def remove_step():
super().remove_step()
<remove specific step removal>
Also, we should add tests.
The style issues can be fixed by running isort
, black
, mypy
, etc. as specified in CONTRIBUTING.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Added some minor suggestions. I can't reproduce the type check error locally, let's see the output of the checks after rerunning with the committed suggestions.
Co-authored-by: Akshita Bhagia <[email protected]>
Co-authored-by: Akshita Bhagia <[email protected]>
Co-authored-by: Akshita Bhagia <[email protected]>
Co-authored-by: Akshita Bhagia <[email protected]>
Co-authored-by: Akshita Bhagia <[email protected]>
No description provided.