Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Remove step' feature for local workspaces #588

Merged
merged 38 commits into from
Oct 5, 2023
Merged

Conversation

pranjali97
Copy link
Contributor

No description provided.

@pranjali97 pranjali97 requested a review from AkshitaB July 12, 2023 20:34
Copy link
Contributor

@AkshitaB AkshitaB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the function in the workspace should be an abstract method: "NotImplementedError" , and this function is specifically for "local_workspace".

The remote workspaces that inherit from local workspace can implement the remove method as follows:

def remove_step():
    super().remove_step()
    <remove specific step removal>

Also, we should add tests.

The style issues can be fixed by running isort, black, mypy, etc. as specified in CONTRIBUTING.md

tango/workspace.py Outdated Show resolved Hide resolved
tango/workspace.py Outdated Show resolved Hide resolved
tango/step_cache.py Outdated Show resolved Hide resolved
tango/step_caches/local_step_cache.py Outdated Show resolved Hide resolved
tango/step_caches/memory_step_cache.py Outdated Show resolved Hide resolved
tango/step_caches/memory_step_cache.py Outdated Show resolved Hide resolved
tango/step_caches/remote_step_cache.py Outdated Show resolved Hide resolved
tango/workspace.py Outdated Show resolved Hide resolved
tests/workspaces/local_workspace_cache_remove_test.py Outdated Show resolved Hide resolved
tests/workspaces/local_workspace_cache_remove_test.py Outdated Show resolved Hide resolved
tests/workspaces/local_workspace_cache_remove_test.py Outdated Show resolved Hide resolved
tests/workspaces/memory_workspace_cache_remove_test.py Outdated Show resolved Hide resolved
@pranjali97 pranjali97 marked this pull request as ready for review July 27, 2023 21:32
Copy link
Contributor

@AkshitaB AkshitaB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Added some minor suggestions. I can't reproduce the type check error locally, let's see the output of the checks after rerunning with the committed suggestions.

tango/integrations/beaker/workspace.py Outdated Show resolved Hide resolved
tango/step_cache.py Outdated Show resolved Hide resolved
tango/step_cache.py Outdated Show resolved Hide resolved
tango/step_caches/local_step_cache.py Outdated Show resolved Hide resolved
tango/step_caches/remote_step_cache.py Outdated Show resolved Hide resolved
tests/integrations/beaker/workspace_test.py Outdated Show resolved Hide resolved
@AkshitaB AkshitaB merged commit 11b5229 into main Oct 5, 2023
21 checks passed
@AkshitaB AkshitaB deleted the remove_step_branch branch October 5, 2023 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants