Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LR schedulers #573

Merged
merged 9 commits into from
Jul 12, 2023
Merged

LR schedulers #573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
60e3283
fix registration
AkshitaB Jun 5, 2023
7101c1e
fix expected output
AkshitaB Jun 5, 2023
8399d76
update changelog
AkshitaB Jun 5, 2023
8a3661d
Merge branch 'main' into torch-lr-schedulers
AkshitaB Jun 5, 2023
5b8365c
Merge branch 'main' into torch-lr-schedulers
AkshitaB Jun 26, 2023
9338c06
fix doctest
AkshitaB Jul 11, 2023
7c365fd
Merge branch 'main' into torch-lr-schedulers
AkshitaB Jul 11, 2023
1b2333f
click's latest version broke things
AkshitaB Jul 11, 2023
1149c5e
update default cluster
AkshitaB Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ env:
WANDB_API_KEY: ${{ secrets.WANDB_API_KEY }}
BEAKER_TOKEN: ${{ secrets.BEAKER_TOKEN }}
BEAKER_WORKSPACE: ai2/tango-testing
BEAKER_DEFAULT_CLUSTER: ai2/tango-gpu-tests
BEAKER_DEFAULT_CLUSTER: ai2/allennlp-cirrascale
BEAKER_IMAGE: petew/tango-testing
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed

- Removed unnecessary code coverage dev requirements.
- Fixed issue where new version of torch caused no LR schedulers to be registered.

## [v1.2.1](https://github.com/allenai/tango/releases/tag/v1.2.1) - 2023-04-06

Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ dependencies = [
"base58",
"xxhash",
"filelock>=3.4,<4.0",
"click>=8.0,<9.0",
"click>=8.0,<8.1.4",
"click-help-colors>=0.9.1,<0.10",
"rich>=12.3,<14.0",
"tqdm>=4.62,<5.0",
Expand Down
4 changes: 2 additions & 2 deletions tango/integrations/torch/optim.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ class LRScheduler(torch.optim.lr_scheduler._LRScheduler, Registrable):
for name, cls in torch.optim.lr_scheduler.__dict__.items():
if (
isinstance(cls, type)
and issubclass(cls, torch.optim.lr_scheduler._LRScheduler)
and not cls == torch.optim.lr_scheduler._LRScheduler
and issubclass(cls, torch.optim.lr_scheduler.LRScheduler)
and not cls == torch.optim.lr_scheduler.LRScheduler
):
LRScheduler.register("torch::" + name)(cls)
3 changes: 3 additions & 0 deletions tango/integrations/transformers/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,8 @@
transformers::AutoModelForImageSegmentation::from_pretrained
transformers::AutoModelForInstanceSegmentation::from_config
transformers::AutoModelForInstanceSegmentation::from_pretrained
transformers::AutoModelForMaskGeneration::from_config
transformers::AutoModelForMaskGeneration::from_pretrained
transformers::AutoModelForMaskedImageModeling::from_config
transformers::AutoModelForMaskedImageModeling::from_pretrained
transformers::AutoModelForMaskedLM::from_config
Expand Down Expand Up @@ -159,6 +161,7 @@
transformers::inverse_sqrt
transformers::linear
transformers::polynomial
transformers::reduce_lr_on_plateau

- :class:`~tango.integrations.torch.DataCollator`: All data collators from transformers
are registered according to their class name (e.g. "transformers::DefaultDataCollator").
Expand Down