Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Fairscale, move functionality to Torch FSDP #560

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 2, 2023

Bumps sentencepiece from 0.1.98 to 0.1.99.

Release notes

Sourced from sentencepiece's releases.

v0.1.99

Major changes

N/A

New features

N/A

Bug fixes & minor changes

v0.1.99pre1

v0.1.99 pre release for testing.

Commits
  • 3863f76 increases the max number of threads
  • 25b64fc Fix the test error on windows
  • bb0b610 Fix the ULM training bugs
  • ba44ab1 Fix bugs in the handling of duplicated bigrams
  • 69d34c7 prepare for v0.1.99
  • d9a2b21 Fix bugs the seed score computation.
  • See full diff in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [sentencepiece](https://github.com/google/sentencepiece) from 0.1.98 to 0.1.99.
- [Release notes](https://github.com/google/sentencepiece/releases)
- [Commits](google/sentencepiece@v0.1.98...v0.1.99)

---
updated-dependencies:
- dependency-name: sentencepiece
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels May 2, 2023
Bumps [sentencepiece](https://github.com/google/sentencepiece) from 0.1.98 to 0.1.99.
- [Release notes](https://github.com/google/sentencepiece/releases)
- [Commits](google/sentencepiece@v0.1.98...v0.1.99)

---
updated-dependencies:
- dependency-name: sentencepiece
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/pip/sentencepiece-0.1.99 branch from 60b36fc to d141201 Compare May 8, 2023 19:13
@dirkgr
Copy link
Member

dirkgr commented May 9, 2023

@epwalsh, something bad happened to the cluster that Tango runs its tests against?

@dirkgr
Copy link
Member

dirkgr commented May 9, 2023

Ah, Beaker removed support for cloud clusters altogether.

@dirkgr dirkgr changed the title Bump sentencepiece from 0.1.98 to 0.1.99 Remove Fairscale, move functionality to Torch FSDP May 10, 2023
@epwalsh epwalsh mentioned this pull request May 10, 2023
Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 5, 2024

A newer version of sentencepiece exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant