Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set fs_local_rank as global_rank when FS_LOCAL_RANK is not available #456

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Set fs_local_rank as global_rank when FS_LOCAL_RANK is not available #456

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5de468b
get_fs_local_rank
Feb 18, 2024
d2c2982
Merge branch 'main' into fix_fs_rank
dirkgr Feb 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion olmo/torch_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def get_fs_local_rank() -> int:
if all ranks share the same filesystem then `get_fs_local_rank()` will be equivalent to `get_global_rank()`,
but if nodes do not share the same filesystem then `get_fs_local_rank()` will be equivalent to `get_local_rank()`.
"""
return int(os.environ.get("FS_LOCAL_RANK") or get_local_rank())
return int(os.environ.get("FS_LOCAL_RANK") or get_global_rank())


def move_to_device(o: T, device: torch.device) -> T:
Expand Down
Loading