Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeepSpeed #384

Draft
wants to merge 39 commits into
base: main
Choose a base branch
from
Draft

DeepSpeed #384

wants to merge 39 commits into from

Conversation

Muennighoff
Copy link
Collaborator

@Muennighoff Muennighoff commented Nov 27, 2023

  • Does not yet support checkpointing
  • configs/olmo-small-ablation-lumi-deepspeed.yaml is the same as configs/olmo-small-ablation-lumi.yaml except for deepspeed: true & init_device: cpu
  • scripts/lumi/olmo-small-ablation-on-lumi-test.sh is the same as scripts/lumi/olmo-small-ablation-on-lumi-test-deepspeed.sh except for export CONFIG_PATH=configs/olmo-small-ablation-lumi-deepspeed.yaml

olmo/train.py Outdated Show resolved Hide resolved
@Muennighoff
Copy link
Collaborator Author

Muennighoff commented Feb 5, 2024

For future reference, this PR works but we are not merging it as there's no major speed-ups and it's not clean yet. Attached is a comparison of the throughput with this integration vs FSDP :)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant