feature: Draw motion vectors #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ShrimpCryptid
force-pushed
the
feature/motion-vectors
branch
from
238398b to
cca9dba
Compare
ShrimpCryptid
requested review from
meganrm and
rugeli
and removed request for
a team
ShrimpCryptid
commented
Nov 13, 2024
ShrimpCryptid
commented
Nov 13, 2024
ShrimpCryptid
commented
Nov 13, 2024
Comment on lines
+148
to
+157
| export const VECTOR_KEY_MOTION_DELTA = "_motion_"; | ||
|
|
||
| export const getDefaultVectorConfig = (): VectorConfig => ({ | ||
| visible: false, | ||
| key: VECTOR_KEY_MOTION_DELTA, | ||
| timeIntervals: 5, | ||
| color: new Color(0x000000), | ||
| scaleFactor: 4, | ||
| }); | ||
|
|
There was a problem hiding this comment.
Move to constants?
There was a problem hiding this comment.
Going to leave this for a follow-up PR because otherwise it'll make the code diff messier
ShrimpCryptid
commented
Nov 14, 2024
ShrimpCryptid
commented
Nov 14, 2024
ShrimpCryptid
commented
Nov 14, 2024
rugeli
reviewed
Nov 18, 2024
Comment on lines
+127
to
+132
| // o <- normVectorEnd | ||
| // /|\ | ||
| // / | \ <- arrow head maintains onscreen pixel length with zoom | ||
| // | | ||
| // | | ||
| // o <- normVectorStart |
meganrm
reviewed
Nov 19, 2024
meganrm
reviewed
Nov 19, 2024
meganrm
reviewed
Nov 19, 2024
meganrm
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes #42, "visualize XY movement delta." This PR gets a functional implementation of vector lines into TFE! They can now be toggled on and off, and parameters like smoothing and scaling can be edited from a new settings area.
There are a number of spin-off issues that I've created that will be follow-ups to this PR.
Solution
This is a big one, but I think it's split into relatively understandable chunks! I'll be sending a meeting invite to whoever's assigned to this PR so I can walk through it.
VectorFieldclass, which manages a Three.JS line used for rendering the vector arrows.VectorFieldcalculates the vertices for ALL objects across ALL timepoints into a big buffer, then only renders slices of it based on the current frame.Type of change
Steps to Verify:
Screenshots (optional):
Small-volume.25.mp4
Keyfiles (delete if not relevant):
SUGGESTED REVIEW ORDER:
math_utils.ts-> Deltas are calculated here!types.ts-> Vector configurationSharedWorkerPool.ts+worker.ts-> Delta calculations can be triggered asynchronously on workers.Viewer+react_utils.ts-> Manages synchronizing react state and delta calculationColorizeCanvas+VectorField-> actually renders the vectors to the screenVectoFieldSettings-> new settings area