Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Arrow key keybinds still change time when other inputs are being used #308

Closed
ShrimpCryptid opened this issue Apr 5, 2024 · 0 comments · Fixed by #444
Closed

Bug: Arrow key keybinds still change time when other inputs are being used #308

ShrimpCryptid opened this issue Apr 5, 2024 · 0 comments · Fixed by #444
Labels
bug Something isn't working

Comments

@ShrimpCryptid
Copy link
Contributor

Description

Split out from #98.

  • The left/right arrow keys are currently mapped so they advance the current timestamp.
  • When selecting/editing text in input boxes (or on range sliders, etc.), pressing the left or right arrow keys causes the current timestamp to also advance or reverse.

Expected Behavior

  • Time should not be affected when other inputs are focused. Add a listener to check for the currently focused item...?

List of inputs that should override time keybinding behavior:

  • Number and string inputs
  • Sliders

Reproduction

A minimal example that exhibits the behavior.

Environment

Any additional information about your environment. E.g. OS version, python version, browser etc.

@ShrimpCryptid ShrimpCryptid added bug Something isn't working ux-implementation UX research completed, this ticket is ready for implementation. and removed ux-implementation UX research completed, this ticket is ready for implementation. labels Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant