Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Arrow keys no longer advance time when focused on an input #444

Merged
merged 1 commit into from
Sep 30, 2024
Merged

fix: Arrow keys no longer advance time when focused on an input #444

merged 1 commit into from
Sep 30, 2024

Conversation

ShrimpCryptid
Copy link
Contributor

@ShrimpCryptid ShrimpCryptid commented Sep 26, 2024 •
edited
Loading

Problem

Closes #308, "arrow keys still change time when other inputs are being used."

Estimated review size: tiny, 1-2 minutes

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Steps to Verify:

  1. Open TFE and open the export field. Try editing the prefix and pressing the left or right arrow keys. The timestamp will change. https://timelapse.allencell.org/
  2. Repeat with fixed (!!!) preview link: https://allen-cell-animated.github.io/timelapse-colorizer/pr-preview/pr-444/ (The timestamp should not change!)

@ShrimpCryptid ShrimpCryptid added the bug Something isn't working label Sep 26, 2024
@ShrimpCryptid ShrimpCryptid self-assigned this Sep 26, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 26, 2024 •
edited
Loading

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-09-30 18:47 UTC

@github-actions GitHub Actions
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 77.1% 4810 / 6238
🔵 Statements 77.1% 4810 / 6238
🔵 Functions 58.68% 125 / 213
🔵 Branches 81.78% 404 / 494
File CoverageNo changed files found.
Generated in workflow #1147

@ShrimpCryptid ShrimpCryptid marked this pull request as ready for review September 27, 2024 00:21
@ShrimpCryptid ShrimpCryptid requested a review from a team as a code owner September 27, 2024 00:21
@ShrimpCryptid ShrimpCryptid requested review from meganrm and rugeli and removed request for a team September 27, 2024 00:21
rugeli
rugeli approved these changes Sep 30, 2024
View reviewed changes
Copy link

@rugeli rugeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShrimpCryptid ShrimpCryptid merged commit e97fa10 into main Sep 30, 2024
2 checks passed
@ShrimpCryptid ShrimpCryptid deleted the fix/arrow-key-input branch September 30, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meganrm meganrm meganrm approved these changes

@rugeli rugeli rugeli approved these changes

Assignees

@ShrimpCryptid ShrimpCryptid

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Arrow key keybinds still change time when other inputs are being used
3 participants
@ShrimpCryptid @meganrm @rugeli