Fixed reading secret file (#15)

action/common.go

@@ -73,7 +73,7 @@ func getCommonParameters(c *cli.Context) CommonConfig {
 }
 
 // GetSecretFromFile reads a value from provided file
-func (config CommonConfig) GetSecretFromFile(secretFile string) error {
+func (config *CommonConfig) GetSecretFromFile(secretFile string) error {
 	secret, err := ioutil.ReadFile(secretFile)
 	if err != nil {
 		return fmt.Errorf("unable to read secret from file: %s, %s", secretFile, err)

action/common_test.go

@@ -0,0 +1,27 @@
+package action
+
+import (
+	"io/ioutil"
+	"os"
+	"testing"
+
+	"github.com/stretchr/testify/require"
+)
+
+func TestGetSecretFromFileCorrectly(t *testing.T) {
+	config := CommonConfig{
+		VaaSKeyFile: "vaas-secret",
+	}
+	secretContent := "secret token"
+
+	data := []byte(secretContent)
+	err := ioutil.WriteFile(config.VaaSKeyFile, data, 0644)
+	require.NoError(t, err)
+
+	err = config.GetSecretFromFile(config.VaaSKeyFile)
+	require.NoError(t, err)
+	require.Equal(t, config.VaaSKey, secretContent)
+
+	err = os.Remove(config.VaaSKeyFile)
+	require.NoError(t, err)
+}