Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dnd polyfill chunk #871

Merged
merged 2 commits into from
Mar 8, 2022
Merged

Dnd polyfill chunk #871

merged 2 commits into from
Mar 8, 2022

Conversation

plesiecki
Copy link
Collaborator

@plesiecki plesiecki commented Mar 8, 2022 •
edited
Loading

@github-actions
Copy link

github-actions bot commented Mar 8, 2022

⏱️ Lighthouse report: https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1646730595643-8120.report.html

@plesiecki plesiecki force-pushed the dnd-polyfill-chunk branch from a68c184 to 1731810 Compare March 8, 2022 09:11
@github-actions
Copy link

github-actions bot commented Mar 8, 2022

✅ Deployed successfully to: https://turnilo-dnd-polyfill-chunk-gmbbyye42a-ew.a.run.app

@github-actions
Copy link

github-actions bot commented Mar 8, 2022

⏱️ Lighthouse report: https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1646730917701-33341.report.html

@plesiecki plesiecki force-pushed the dnd-polyfill-chunk branch from 1731810 to 9353c4d Compare March 8, 2022 09:17
@github-actions
Copy link

github-actions bot commented Mar 8, 2022

✅ Deployed successfully to: https://turnilo-dnd-polyfill-chunk-gmbbyye42a-ew.a.run.app

@plesiecki plesiecki force-pushed the dnd-polyfill-chunk branch from 9353c4d to a8cd72a Compare March 8, 2022 09:17
@github-actions
Copy link

github-actions bot commented Mar 8, 2022

⏱️ Lighthouse report: https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1646731304144-20506.report.html

@github-actions
Copy link

github-actions bot commented Mar 8, 2022

⏱️ Lighthouse report: https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1646731311346-22361.report.html

@github-actions
Copy link

github-actions bot commented Mar 8, 2022 •
edited
Loading

size-limit report 📦

Path Size
build/public/main.js 1.94 MB (-0.08% 🔽)
build/public/polyfills.es5.js 42.51 KB (+100% 🔺)
build/public/dnd.es5.js 4.56 KB (+100% 🔺)

@github-actions
Copy link

github-actions bot commented Mar 8, 2022

✅ Deployed successfully to: https://turnilo-dnd-polyfill-chunk-gmbbyye42a-ew.a.run.app

1 similar comment
@github-actions
Copy link

github-actions bot commented Mar 8, 2022

✅ Deployed successfully to: https://turnilo-dnd-polyfill-chunk-gmbbyye42a-ew.a.run.app

@plesiecki plesiecki force-pushed the dnd-polyfill-chunk branch from a8cd72a to da21e69 Compare March 8, 2022 09:28
@github-actions
Copy link

github-actions bot commented Mar 8, 2022

⏱️ Lighthouse report: https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1646732009352-83082.report.html

@github-actions
Copy link

github-actions bot commented Mar 8, 2022

✅ Deployed successfully to: https://turnilo-dnd-polyfill-chunk-gmbbyye42a-ew.a.run.app

@plesiecki plesiecki force-pushed the dnd-polyfill-chunk branch from da21e69 to 56e5d47 Compare March 8, 2022 09:36
@github-actions
Copy link

github-actions bot commented Mar 8, 2022

⏱️ Lighthouse report: https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1646732397635-41040.report.html

@github-actions
Copy link

github-actions bot commented Mar 8, 2022

✅ Deployed successfully to: https://turnilo-dnd-polyfill-chunk-gmbbyye42a-ew.a.run.app

@plesiecki plesiecki force-pushed the dnd-polyfill-chunk branch from 56e5d47 to 0851f73 Compare March 8, 2022 09:43
@github-actions
Copy link

github-actions bot commented Mar 8, 2022

⏱️ Lighthouse report: https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1646732896328-36724.report.html

@plesiecki plesiecki force-pushed the dnd-polyfill-chunk branch from 0851f73 to 70ad13e Compare March 8, 2022 09:49
@github-actions
Copy link

github-actions bot commented Mar 8, 2022

✅ Deployed successfully to: https://turnilo-dnd-polyfill-chunk-gmbbyye42a-ew.a.run.app

@github-actions
Copy link

github-actions bot commented Mar 8, 2022

⏱️ Lighthouse report: https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1646733268092-33470.report.html

@github-actions
Copy link

github-actions bot commented Mar 8, 2022

✅ Deployed successfully to: https://turnilo-dnd-polyfill-chunk-gmbbyye42a-ew.a.run.app

@plesiecki plesiecki marked this pull request as ready for review March 8, 2022 10:15
@plesiecki plesiecki mentioned this pull request Mar 8, 2022
Open
12 tasks
@plesiecki plesiecki force-pushed the dnd-polyfill-chunk branch from 70ad13e to 1dd9e1a Compare March 8, 2022 10:46
@github-actions
Copy link

github-actions bot commented Mar 8, 2022

⏱️ Lighthouse report: https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1646736647824-21568.report.html

@github-actions
Copy link

github-actions bot commented Mar 8, 2022

✅ Deployed successfully to: https://turnilo-dnd-polyfill-chunk-gmbbyye42a-ew.a.run.app

@plesiecki plesiecki force-pushed the dnd-polyfill-chunk branch from 1dd9e1a to 9ef0121 Compare March 8, 2022 13:53
adrianmroz-allegro
adrianmroz-allegro approved these changes Mar 8, 2022
View reviewed changes
config/webpack.prod.js
merge.smart(commonConfig, prodConfig, polyfillsConfig, bundleAnalyzerConfig),
merge.smart(commonConfig, prodConfig, es5Config),
merge.smart(commonConfig, prodConfig, bundleAnalyzerConfig),
merge.smart(commonConfig, prodConfig, es5Config, polyfillsConfig),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense that we serve polyfills only for es5 browsers!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, DnD polyfill has some code to transpile 🤠

@github-actions
Copy link

github-actions bot commented Mar 8, 2022

⏱️ Lighthouse report: https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1646747846980-73081.report.html

@github-actions
Copy link

github-actions bot commented Mar 8, 2022

✅ Deployed successfully to: https://turnilo-dnd-polyfill-chunk-gmbbyye42a-ew.a.run.app

@plesiecki plesiecki merged commit 68ddc52 into master Mar 8, 2022
@plesiecki plesiecki deleted the dnd-polyfill-chunk branch March 8, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianmroz-allegro adrianmroz-allegro adrianmroz-allegro approved these changes

Assignees
No one assigned
Labels
technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plesiecki @adrianmroz-allegro