Build two client bundles — ES5 and ES6 #855
Conversation
plesiecki
force-pushed
the
babel-build
branch
2 times, most recently
from
ac4bedf to
3381f3c
Compare
|
✅ Deployed successfully to: https://turnilo-babel-build-gmbbyye42a-ew.a.run.app |
2 similar comments
|
✅ Deployed successfully to: https://turnilo-babel-build-gmbbyye42a-ew.a.run.app |
|
✅ Deployed successfully to: https://turnilo-babel-build-gmbbyye42a-ew.a.run.app |
plesiecki
force-pushed
the
babel-build
branch
from
3381f3c to
162f804
Compare
|
✅ Deployed successfully to: https://turnilo-babel-build-gmbbyye42a-ew.a.run.app |
plesiecki
force-pushed
the
babel-build
branch
from
162f804 to
3c4beb3
Compare
|
✅ Deployed successfully to: https://turnilo-babel-build-gmbbyye42a-ew.a.run.app |
|
✅ Deployed successfully to: https://turnilo-babel-build-gmbbyye42a-ew.a.run.app |
plesiecki
force-pushed
the
babel-build
branch
2 times, most recently
from
2819bd9 to
7941741
Compare
|
✅ Deployed successfully to: https://turnilo-babel-build-gmbbyye42a-ew.a.run.app |
2 similar comments
|
✅ Deployed successfully to: https://turnilo-babel-build-gmbbyye42a-ew.a.run.app |
|
✅ Deployed successfully to: https://turnilo-babel-build-gmbbyye42a-ew.a.run.app |
|
✅ Deployed successfully to: https://turnilo-babel-build-gmbbyye42a-ew.a.run.app |
| module.exports = (api) => { | ||
| api.cache(true); | ||
| return { | ||
| passPerPreset: true, |
There was a problem hiding this comment.
This helps with VisualizationManifest class which only has fileds declaration within constructor.
| @@ -190,8 +190,6 @@ export class Essence extends ImmutableRecord<EssenceValue>(defaultEssence) { | |||
| return timeFilter; | |||
| } | |||
|
|
|||
| public visResolve: Resolve; | |||
There was a problem hiding this comment.
How did app broke (build, e2e?) so you had to remove this line? Because in theory this is correct code and I'm wondering if we will get more cryptic errors like this?
There was a problem hiding this comment.
It builds ok but it causes visResolve to be a undefined during runtime. Then e2e failed miserably.
Actually I expected more cases like this but it was single one. I'm not sure why that single field out of all fields is re-declare. I assume that parent class declares it and it's superfluous 🤔
| @@ -190,8 +190,6 @@ export class Essence extends ImmutableRecord<EssenceValue>(defaultEssence) { | |||
| return timeFilter; | |||
| } | |||
|
|
|||
| public visResolve: Resolve; | |||
There was a problem hiding this comment.
This causes visResolve to be a undefined during runtime.
There was a problem hiding this comment.
So probably we will encounter bunch of different weird issues.
|
✅ Deployed successfully to: https://turnilo-babel-build-gmbbyye42a-ew.a.run.app |
|
✅ Deployed successfully to: https://turnilo-babel-build-gmbbyye42a-ew.a.run.app |
|
✅ Deployed successfully to: https://turnilo-babel-build-gmbbyye42a-ew.a.run.app |
|
✅ Deployed successfully to: https://turnilo-babel-build-gmbbyye42a-ew.a.run.app |
…elper code and save on codesize
|
✅ Deployed successfully to: https://turnilo-babel-build-gmbbyye42a-ew.a.run.app |
1 similar comment
|
✅ Deployed successfully to: https://turnilo-babel-build-gmbbyye42a-ew.a.run.app |
#845