Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce basic lighthouse-ci #848

Merged
merged 1 commit into from
Feb 24, 2022
Merged

Introduce basic lighthouse-ci #848

merged 1 commit into from
Feb 24, 2022

Conversation

plesiecki
Copy link
Collaborator

@plesiecki plesiecki commented Feb 22, 2022 •
edited
Loading

@github-actions
Copy link

✅ Deployed successfully to: https://turnilo-lhci-gmbbyye42a-ew.a.run.app

@github-actions
Copy link

✅ Deployed successfully to: https://turnilo-lhci-gmbbyye42a-ew.a.run.app

@github-actions
Copy link

✅ Deployed successfully to: https://turnilo-lhci-gmbbyye42a-ew.a.run.app

@github-actions
Copy link

✅ Deployed successfully to: https://turnilo-lhci-gmbbyye42a-ew.a.run.app

@github-actions
Copy link

✅ Deployed successfully to: https://turnilo-lhci-gmbbyye42a-ew.a.run.app

@github-actions
Copy link

✅ Deployed successfully to: https://turnilo-lhci-gmbbyye42a-ew.a.run.app

@plesiecki plesiecki force-pushed the lhci branch 4 times, most recently from 9a97db8 to 9603b48 Compare February 23, 2022 11:45
@github-actions
Copy link

✅ Deployed successfully to: https://turnilo-lhci-gmbbyye42a-ew.a.run.app

2 similar comments
@github-actions
Copy link

✅ Deployed successfully to: https://turnilo-lhci-gmbbyye42a-ew.a.run.app

@github-actions
Copy link

✅ Deployed successfully to: https://turnilo-lhci-gmbbyye42a-ew.a.run.app

@github-actions
Copy link

✅ Deployed successfully to: https://turnilo-lhci-gmbbyye42a-ew.a.run.app

@plesiecki plesiecki force-pushed the lhci branch 2 times, most recently from d3d4a69 to c618809 Compare February 23, 2022 12:14
@github-actions
Copy link

✅ Deployed successfully to: https://turnilo-lhci-gmbbyye42a-ew.a.run.app

1 similar comment
@github-actions
Copy link

✅ Deployed successfully to: https://turnilo-lhci-gmbbyye42a-ew.a.run.app

@github-actions
Copy link

✅ Deployed successfully to: https://turnilo-lhci-gmbbyye42a-ew.a.run.app

@github-actions
Copy link

✅ Deployed successfully to: https://turnilo-lhci-gmbbyye42a-ew.a.run.app

@plesiecki plesiecki marked this pull request as ready for review February 23, 2022 12:39
@plesiecki plesiecki changed the title introduce basic lighthouse-ci Introduce basic lighthouse-ci Feb 23, 2022
adrianmroz-allegro
adrianmroz-allegro reviewed Feb 23, 2022
View reviewed changes
@github-actions
Copy link

✅ Deployed successfully to: https://turnilo-lhci-gmbbyye42a-ew.a.run.app

@github-actions
Copy link

✅ Deployed successfully to: https://turnilo-lhci-gmbbyye42a-ew.a.run.app

fpoon
fpoon suggested changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@fpoon fpoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, though I have some suggestions on improving workflow triggers

@github-actions
Copy link

✅ Deployed successfully to: https://turnilo-lhci-gmbbyye42a-ew.a.run.app

mkuthan
mkuthan approved these changes Feb 24, 2022
View reviewed changes
Copy link
Member

@mkuthan mkuthan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New tool in the toolbox and first usage of GH action build artifact :) Thanks!

@plesiecki plesiecki merged commit 4723b11 into master Feb 24, 2022
@plesiecki plesiecki deleted the lhci branch February 24, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianmroz-allegro adrianmroz-allegro adrianmroz-allegro approved these changes

@mkuthan mkuthan mkuthan approved these changes

@fpoon fpoon fpoon approved these changes

Assignees
No one assigned
Labels
enhancement New feature technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@plesiecki @mkuthan @fpoon @adrianmroz-allegro