Feature/scatterplot heatmap #844
Conversation
|
✅ Deployed successfully to: https://turnilo-feature-scatterplot-heatmap-gmbbyye42a-ew.a.run.app |
|
Link to local turnilo just in case. Ticks count is not so reliable 🤔 Nagranie.z.ekranu.2022-02-22.o.15.56.31.mov |
I blame ticks :) Will look into it, nice we have e2e test for ticks count! |
| const xPosition = xScale(x0); | ||
| const width = xScale(x1) - xPosition; | ||
| const yPosition = yScale(y1); | ||
| const height = yScale(y0) - yScale(y1); |
There was a problem hiding this comment.
| const height = yScale(y0) - yScale(y1); | |
| const height = yScale(y0) - yPosition; |
|
|
|
✅ Deployed successfully to: https://turnilo-feature-scatterplot-heatmap-gmbbyye42a-ew.a.run.app |
We should have one bin less than ticks. Do not filter out 0 value for ticks.
|
✅ Deployed successfully to: https://turnilo-feature-scatterplot-heatmap-gmbbyye42a-ew.a.run.app |
If it is stupid and it works, it is not stupid
|
✅ Deployed successfully to: https://turnilo-feature-scatterplot-heatmap-gmbbyye42a-ew.a.run.app |
|
✅ Deployed successfully to: https://turnilo-feature-scatterplot-heatmap-gmbbyye42a-ew.a.run.app |
|
✅ Deployed successfully to: https://turnilo-feature-scatterplot-heatmap-gmbbyye42a-ew.a.run.app |
There was a problem hiding this comment.
A few questions:
- blue colour for the summary - intentional or not?
- settings label is "Show heatmap summary" but legend label is just a "count" - could we make it more consistent?
- have you checked CSS theming compatibility?
- have you checked "lower is better" for timeshift?
|
Note to self, another issue to look into: Nagranie.z.ekranu.2022-02-24.o.12.11.40.mov |
Blue is intentional:
Currently Turnilo does not have support for a secondary color. And I think we don't have a possibility to pass to TS colors defined in CSS. I'd leave it as is for now. Created na issue #852 so that it is addressed.
Renamed to "Count per summary bin" so that it includes summary, but is it enough or should we use split title here in some form as well? Naming is the hardest part, we can brainstorm this, if you want. I'm open to suggestions :)
In https://github.com/allegro/turnilo/pull/843/files I used |
|
✅ Deployed successfully to: https://turnilo-feature-scatterplot-heatmap-gmbbyye42a-ew.a.run.app |
src/client/visualizations/scatterplot/utils/get-plotting-data.ts
Outdated
Show resolved
Hide resolved
|
✅ Deployed successfully to: https://turnilo-feature-scatterplot-heatmap-gmbbyye42a-ew.a.run.app |
No description provided.