Migrated metrics to prometheus #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozjan
reviewed
Oct 1, 2024
kozjan
reviewed
Oct 1, 2024
| sample.stop(meterRegistry.timer("snapshot-factory.new-snapshot.time")) | ||
| sample.stop( | ||
| meterRegistry.timer( | ||
| "snapshot-factory.seconds", |
There was a problem hiding this comment.
maybe snapshot_factory to be consistent with other metrics?
There was a problem hiding this comment.
yea, I was looking at some our other metrics, but looks like this way would be better, I changed to dots everywhere
kozjan
reviewed
Oct 1, 2024
| groupSample.stop(meterRegistry.timer("snapshot-factory.get-snapshot-for-group.time")) | ||
| groupSample.stop( | ||
| meterRegistry.timer( | ||
| "snapshot-factory.seconds", |
There was a problem hiding this comment.
same here - snapshot_factory for consistency
kozjan
reviewed
Oct 1, 2024
| .checkpoint("snapshot-updater-groups-published") | ||
| .name("snapshot-updater-groups-published").metrics() | ||
| .name("snapshot-updater.count.total") |
There was a problem hiding this comment.
snapshot_updater/snapshot.updater - . is mapped to _, right?
There was a problem hiding this comment.
. is, - isn't
kozjan
reviewed
Oct 1, 2024
...main/kotlin/pl/allegro/tech/servicemesh/envoycontrol/consul/services/ConsulServiceChanges.kt
Show resolved
Hide resolved
Ferdudas97
requested changes
Oct 1, 2024
...pl/allegro/tech/servicemesh/envoycontrol/server/callbacks/MetricsDiscoveryServerCallbacks.kt
Outdated
Show resolved
Hide resolved
...pl/allegro/tech/servicemesh/envoycontrol/server/callbacks/MetricsDiscoveryServerCallbacks.kt
Outdated
Show resolved
Hide resolved
| .name("snapshot-updater-merged").metrics() | ||
| .name("snapshot.updater.count.total") | ||
| .tag("status", "merged") | ||
| .tag("type", "global") |
Co-authored-by: kozjan <[email protected]>
KSmigielski
reviewed
Oct 1, 2024
| meterRegistry.gauge(metricName, Tags.of("status", "instance-changed"), it.instanceChanges) | ||
| meterRegistry.gauge(metricName, Tags.of("status", "snapshot-changed"), it.snapshotChanges) | ||
| meterRegistry.gauge("cache.groups.count", it.cacheGroupsCount) | ||
| it.meterRegistry.more().counter("services.watch.errors.total", listOf(), it.errorWatchingServices) |
There was a problem hiding this comment.
I think it would be better to have consistent name. So if we have watched-services, then it should be watched-services.errors.total
| }, 0, interval, TimeUnit.SECONDS) | ||
| }, FluxSink.OverflowStrategy.LATEST) | ||
| return aclFlux.doOnCancel { | ||
| meterRegistry.counter("cross-dc-synchronization.cancelled").increment() | ||
| meterRegistry.counter("cross.dc.synchronization.cancelled").increment() |
There was a problem hiding this comment.
Why there is not total at the end of metric name?
...main/kotlin/pl/allegro/tech/servicemesh/envoycontrol/consul/services/ConsulServiceChanges.kt
Outdated
Show resolved
Hide resolved
nastassia-dailidava
force-pushed
the
migrate-metrics
branch
4 times, most recently
from
25bef87
to
d4d5cf3
Compare
nastassia-dailidava
force-pushed
the
migrate-metrics
branch
from
d4d5cf3
to
1b340fa
Compare
…oved reactor micrometer)
…oved reactor micrometer)
|
https://pastebin.cert.qxlint/view/raw/370ffe1e the resulting metrics |
KSmigielski
approved these changes
Oct 8, 2024
kozjan
approved these changes
Oct 8, 2024
Ferdudas97
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.