allegro-internal/flex-roadmap#804 Added/removed logs #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozjan
reviewed
Sep 17, 2024
envoy-control-core/src/main/java/pl/allegro/tech/servicemesh/envoycontrol/SimpleCache.java
Show resolved
Hide resolved
kozjan
reviewed
Sep 17, 2024
envoy-control-core/src/main/java/pl/allegro/tech/servicemesh/envoycontrol/SimpleCache.java
Show resolved
Hide resolved
kozjan
reviewed
Sep 17, 2024
envoy-control-core/src/main/java/pl/allegro/tech/servicemesh/envoycontrol/SimpleCache.java
Show resolved
Hide resolved
kozjan
reviewed
Sep 17, 2024
| @@ -268,12 +268,15 @@ public DeltaWatch createDeltaWatch( | |||
| String version) { | |||
| long watchId = watchCount.incrementAndGet(); | |||
| status.setWatch(watchId, watch); | |||
| watch.setStop(() -> status.removeWatch(watchId)); | |||
| watch.setStop(() -> { | |||
| LOGGER.debug("removing watch {}", watchId); | |||
There was a problem hiding this comment.
how will this help you with investigating the issue of removing snapshots with existing watches?
There was a problem hiding this comment.
snapshot is getting cleared when watch is removed and id of watch can be connected to the event when it was created while that one can be connected to events when instances of a services were changed, not sure if that will be enough, but right now there's literally nothing that can help debug it
kozjan
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.