Added compression properties to node metadata #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastassia-dailidava
force-pushed
the
compression-filter-2
branch
from
0a9100a
to
ef66026
Compare
Ferdudas97
approved these changes
Jul 31, 2024
kozjan
reviewed
Jul 31, 2024
Comment on lines
+384
to
+385
| var gzip = CompressorProperties() | ||
| var brotli = CompressorProperties() |
There was a problem hiding this comment.
how does chooseFirst work now that gzip and brotli use the same properties?
There was a problem hiding this comment.
so according to the docs if several filters have chooseFirst = true then the priority will be chosen by their order in configuration, but I'm going to configure as it was before but in aec settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/allegro-internal/flex-roadmap/issues/687