allegro-internal/flex-roadmap#819 Migrated metrics to prometheus (lint)

allegro · Oct 1, 2024 · 5edcb15 · 5edcb15
1 parent 4416446
commit 5edcb15
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/...core/src/main/kotlin/pl/allegro/tech/servicemesh/envoycontrol/snapshot/SnapshotUpdater.kt b/...core/src/main/kotlin/pl/allegro/tech/servicemesh/envoycontrol/snapshot/SnapshotUpdater.kt
@@ -162,7 +162,7 @@ class SnapshotUpdater(
 
     private fun snapshotTimer(serviceName: String) = if (properties.metrics.cacheSetSnapshot) {
         meterRegistry.timer(
-            "simple-cache.duration.seconds", Tags.of("service", serviceName, "operation", "set-snapshot")
+            "simple.cache.duration.seconds", Tags.of("service", serviceName, "operation", "set-snapshot")
         )
     } else {
         noopTimer

diff --git a/.../src/test/kotlin/pl/allegro/tech/servicemesh/envoycontrol/metrics/ThreadPoolMetricTest.kt b/.../src/test/kotlin/pl/allegro/tech/servicemesh/envoycontrol/metrics/ThreadPoolMetricTest.kt
@@ -29,14 +29,14 @@ class ThreadPoolMetricTest {
         val metricNames = listOf("executor.completed", "executor.active", "executor.queued", "executor.pool.size")
             .map { "envoy-control.$it" }
 
-        val metricMap = listOf(
+        val executorNames = listOf(
             "grpc-server-worker",
             "grpc-worker-event-loop",
             "snapshot-update",
             "group-snapshot"
         ).associateWith { metricNames }
 
-        assertThat(metricMap.entries).allSatisfy {
+        assertThat(executorNames.entries).allSatisfy {
             assertThat(it.value.all { metricName ->
                 meterRegistry.meters.any { meter ->
                     meter.id.name == metricName && meter.id.tags.contains(