Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Gemma model #15

Merged
merged 11 commits into from
Mar 4, 2024
Merged

Conversation

megatron6000
Copy link
Collaborator

@megatron6000 megatron6000 commented Mar 1, 2024

Feature Description

This PR adds support for Gemma models hosted on GCP Model Garden

Added

  • VertexAIGemmaModel class added

TODO:

  • update documentation

allms/models/vertexai_base.py Show resolved Hide resolved
allms/models/vertexai_base.py Outdated Show resolved Hide resolved
docs/index.md Show resolved Hide resolved
@riccardo-alle
Copy link
Contributor

@megatron6000 don't forget to update __all__ and get_available_models() to include Gemma. Actually, can we think about a test that would be trigger if we forget to list a new model? 🤔

@megatron6000
Copy link
Collaborator Author

@megatron6000 don't forget to update __all__ and get_available_models() to include Gemma. Actually, can we think about a test that would be trigger if we forget to list a new model? 🤔

I added a test that checks if models listed in get_available_models() are also included in __all__

docs/api/models/vertexai_gemma.md Show resolved Hide resolved
docs/index.md Show resolved Hide resolved
@riccardo-alle riccardo-alle merged commit 0d4c837 into main Mar 4, 2024
2 checks passed
@riccardo-alle riccardo-alle deleted the add-support-for-gemma-model branch March 4, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants