adding get_available_models() method #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riccardo-alle
requested review from
alle-pawols,
megatron6000 and
alicja-raczkowska
megatron6000
requested changes
Feb 29, 2024
| from allms.models.azure_llama2 import AzureLlama2Model | ||
| from allms.models.azure_mistral import AzureMistralModel | ||
| from allms.models.azure_openai import AzureOpenAIModel | ||
| from allms.models.vertexai_gemini import VertexAIGeminiModel | ||
| from allms.models.vertexai_palm import VertexAIPalmModel | ||
|
|
||
| __all__ = ["AzureOpenAIModel", "AzureLlama2Model", "AzureMistralModel", "VertexAIPalmModel", "VertexAIGeminiModel"] | ||
|
|
||
|
|
||
| def get_available_models() -> dict[str, Type[AbstractModel]]: |
There was a problem hiding this comment.
Add the function to __all__
There was a problem hiding this comment.
Good point. Added
megatron6000
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature Description
This task is about moving the available models listing to
allmsinstead of enumerating them in the client code base.Added
allms.models.get_available_modelsmethod