Removed recursion in find method #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allan2
added a commit
that referenced
this pull request
Mar 15, 2024
This commit adds new Clippy directives. Most lints have been applied, mostly affecting formatting or control flow. `find` function was skipped because it may be replaced with a non-recursive version (#80).
|
|
|
Thank you for this one too! This version of the function is far cleaner IMO. |
|
LGTM! Thank you @vallentin. @sonro merge when ready. |
sonro
added a commit
to sonro/dotenvy
that referenced
this pull request
Jul 17, 2024
This reverts commit e7f398b.
sonro
added a commit
to sonro/dotenvy
that referenced
this pull request
Jul 18, 2024
This reverts commit e7f398b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The title says it all. I refactored
find()and removed the recursion.