Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the 'make install' works #92

Merged
merged 1 commit into from
Jan 23, 2020
Merged

Conversation

jonadem
Copy link
Contributor

@jonadem jonadem commented Jan 23, 2020

For the make install to works, I replaces the spaces in the songs' filenames.
linthesia will now look for resources in the default directory or in the previous 'local' one.

A refactoring can be valuable but it should work as it is.

For the make install to works, I replaces the spaces in the songs' filenames.
linthesia will now look for resources in the default directory or in the previous 'local' one.
Copy link
Owner

@allan-simon allan-simon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonderful !

@allan-simon allan-simon merged commit 9c3c778 into allan-simon:master Jan 23, 2020
@allan-simon
Copy link
Owner

are you using it recently ? (I have to admit that now that I have an accoustic piano, I haven't touched to linthesia for quite some times now)

@jonadem
Copy link
Contributor Author

jonadem commented Jan 23, 2020

A little bit. I gave it another try and I was able to use it this time. It is playable but still a little bit confusing (with #91 and #93). I have a small midi keyboard.

Although, for the moment, I have spent more time in the code than playing with it.

I hope that with this PR, it will be one step closer to be in distributions repositories. :-)

@allan-simon
Copy link
Owner

haha I hope too, 7 years I was sad that the original linthesia package was broken in ubuntu, and I hoped to fix it quickly, and here we are :P

@allan-simon
Copy link
Owner

I don't know if it's also possible to integrate in some way the patch that guy made here #16 , because I remember that I found lacking the possibility to go backward/forward a bit by using arrow keys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants