Feature: Flow states, about v2

[techsmyth]

Only use flowState for the filtering of Callout.

Removed all groups related functionality.

New hook to get the information needed for each of the tabs, including the state information that is then usable for both the tab name and the description.

Moved code around to have the tabbed pages as one layout under the new Space location.

Removed a couple of containers (merged into pages), and also a couple of hooks.

Updated to use refined api on the server.

Updated to use explicit passing around of classificationTagsets as an array

.....

Risk areas / TODOs:

• loading of content behind a dialog
• checking the routing for non-space pages
• getting the parameters for saving as template privilege (ideally from the library, so needs to be passed from even higher) and entitlement (needs collaboration license, also to come in from higher)
• ..
  ======

#7685
#6937
Disclaimer: There are certain hacks here to make the callouts be shown in the correct group when they come with certain flowState set that should NOT be merged. But serve as a proof of concept and display quite well the issue.

Problem:

• For positioning callouts in tabs we use tagsets that are in callout > framing > profile > tagsets.
• In spaces we use tagset.name = 'callout-group'. and there is a full server side implementation to filter and move callouts in between groups.
• In subspaces we use tagset.name = 'flow-state'. and we have a nice client-side implementation to move callouts between states with a drag&drop editor.
• Other server problems: Bad data and missing stuff, see the server PR Innovation Flow in Spaces - Classification tagsets: usage simplification + data migration  server#4995 for more context.

Second Problem:

• We have a very strict implementation for the tabs, we have 4 urls, dashboard, community, subspaces, knowledge base, that goes a bit deep, and it also uses a GraphQL type CalloutGroupName, we need to give flexibility to that, we can keep the 4/5 possible urls but I think we should unify DashboardPage, CommunityPage, SubspacesPage and KnowledgeBasePage and I think they should be a single one that renders the specific components for each section.

Server Actions:

• I would implement some server side filtering at least, the same way we can query callouts (groupNames[...]) { to be able to query callouts by state.
• Groups code needs to be removed or adapted to use flow-states ?

Pending - things that may not be ver difficult and can be continued regardless of server changes

• Add description from the innovation-flow to top-right of the tabs
• Default to the currentState tab when we don't specify a tab in the url
• Add "Custom" tab (there is already some work on this. A fifth tab, so we'll have Dashboard (Home), Community, Subspaces, Knowledge-base and "Custom", when the page is activated through graphql. There is some work already done on this. This custom page will be like knowledgeBase, just a list of callouts. Note that in the past there was a tab called Contribute, maybe some code can be reused.
• Remove the move callout dropdown from the calloutEditForm, we are not moving callouts like this any more.

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.