resource/alicloud_ess_scaling_rule: optimize query rule #7827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| d.SetId(response.ScalingRuleId) | ||
|
|
||
| _, ok := d.GetOk("alarm_dimension") | ||
| d.SetId(fmt.Sprint("false", ":", response.ScalingRuleId)) |
There was a problem hiding this comment.
因为在查询伸缩规则的时候，因为当前后端和CMS之间请求方式的原因 如果查询伸缩规则的时候，同时查询报警任务
可能会出现超时的情况；而目前伸缩规则只有当资源设置了AlarmDimension的时候，才必须查报警任务，而其他场景则不需要查报警任务；查询伸缩规则时，只有请求的AlarmRule设置了True 才查报警任务，否则就不查报警任务，避免绝大多数场景因查伸缩规则的时候同时查报警任务导致查询超时的异常，临时解决绝大部分TF用户查询伸缩组的超时异常。当然这块后续还需要ESS后端和CMS共同优化查询时间太长这个问题。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.